-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat!: remove generic hook, add specific type hooks (#766)
This PR brings the react SDK's evaluation API in-line with other SDKS. It does this by: - adding flag value hooks for each type (these all use common code, with only differing generic args) - adding flag details hooks for each type (again using common code) - adding optional generic constraints for each I think this is important before a non-experimental release for 2 reasons: - it's consistent with our other JS components and other SDKs - it fixes a potential bug if uses accidentally pass the wrong default type :warning: This is a breaking change. --------- Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Michael Beemer <[email protected]>
- Loading branch information
Showing
2 changed files
with
129 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters