feat: use interface for events #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the providers events member an interface to improve flexibility and reduce possible typing issues Signed-off-by: Todd Baert <[email protected]>
toddbaert
requested review from
beeme1mr,
jonathannorris,
luizgribeiro and
lukas-reining
Signed-off-by: Todd Baert <[email protected]>
beeme1mr
reviewed
Jan 31, 2024
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Jan 31, 2024
Signed-off-by: Todd Baert <[email protected]>
jonathannorris
approved these changes
Jan 31, 2024
Co-authored-by: Jonathan Norris <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Jonathan Norris <[email protected]> Signed-off-by: Todd Baert <[email protected]>
beeme1mr
reviewed
Jan 31, 2024
toddbaert
commented
Jan 31, 2024
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Jan 31, 2024
Signed-off-by: Todd Baert <[email protected]>
beeme1mr
reviewed
Jan 31, 2024
beeme1mr
approved these changes
Jan 31, 2024
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
beeme1mr
approved these changes
Jan 31, 2024
lukas-reining
approved these changes
Jan 31, 2024
This was referenced Jan 31, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.25](core-v0.0.24...core-v0.0.25) (2024-01-31) ### ✨ New Features * use interface for events ([#798](#798)) ([b47b1dc](b47b1dc)) ### 🐛 Bug Fixes * removed duped core types ([#800](#800)) ([7cc1e09](7cc1e09)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: openfeature-peer-update-bot <[email protected]> Co-authored-by: openfeature-peer-update-bot <[email protected]>
toddbaert
pushed a commit
that referenced
this pull request
Jan 31, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.12](web-sdk-v0.4.11...web-sdk-v0.4.12) (2024-01-31) ### ✨ New Features * use interface for events ([#798](#798)) ([b47b1dc](b47b1dc)) ### 🐛 Bug Fixes * removed duped core types ([#800](#800)) ([7cc1e09](7cc1e09)) ### 🧹 Chore * **main:** release core 0.0.25 ([#801](#801)) ([53a89ab](53a89ab)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
🤖 I have created a release *beep* *boop* --- ## [1.11.0](server-sdk-v1.10.0...server-sdk-v1.11.0) (2024-01-31) ### ✨ New Features * use interface for events ([#798](#798)) ([b47b1dc](b47b1dc)) ### 🐛 Bug Fixes * removed duped core types ([#800](#800)) ([7cc1e09](7cc1e09)) ### 🧹 Chore * **main:** release core 0.0.25 ([#801](#801)) ([53a89ab](53a89ab)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
This was referenced Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the providers events member an interface to improve flexibility and reduce possible typing issues.
I'm confident this is non-breaking: I've locally updated the my js-contribs to use this, and everything compiled and tested fine.