Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use interface for events #798

Merged
merged 12 commits into from
Jan 31, 2024
4 changes: 3 additions & 1 deletion packages/client/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,9 @@ class MyProvider implements Provider {
}

status?: ProviderStatus | undefined;
events?: OpenFeatureEventEmitter | undefined;

// implement with "new OpenFeatureEventEmitter()", and use "emit()" to emit events
events?: ProviderEventEmitter | undefined;
toddbaert marked this conversation as resolved.
Show resolved Hide resolved
toddbaert marked this conversation as resolved.
Show resolved Hide resolved

initialize?(context?: EvaluationContext | undefined): Promise<void> {
// code to initialize your provider
Expand Down
4 changes: 3 additions & 1 deletion packages/server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,9 @@ class MyProvider implements Provider {
}

status?: ProviderStatus | undefined;
events?: OpenFeatureEventEmitter | undefined;

// implement with "new OpenFeatureEventEmitter()", and use "emit()" to emit events
events?: ProviderEventEmitter | undefined;
toddbaert marked this conversation as resolved.
Show resolved Hide resolved

initialize?(context?: EvaluationContext | undefined): Promise<void> {
// code to initialize your provider
Expand Down
3 changes: 2 additions & 1 deletion packages/shared/src/events/generic-event-emitter.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Logger, ManageLogger, SafeLogger } from '../logger';
import { ProviderEventEmitter } from './provider-event-emitter';
import { EventContext, EventDetails, EventHandler } from './eventing';
import { AllProviderEvents, AnyProviderEvent } from './events';

Expand All @@ -7,7 +8,7 @@ import { AllProviderEvents, AnyProviderEvent } from './events';
* in the event details.
*/
export abstract class GenericEventEmitter<E extends AnyProviderEvent, AdditionalContext extends Record<string, unknown> = Record<string, unknown>>
implements ManageLogger<GenericEventEmitter<E, AdditionalContext>>
implements ProviderEventEmitter<E>, ManageLogger<GenericEventEmitter<E, AdditionalContext>>
{
protected abstract readonly eventEmitter: PlatformEventEmitter;

Expand Down
2 changes: 2 additions & 0 deletions packages/shared/src/events/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
export * from './provider-event-emitter';
export * from './event-utils';
export * from './eventing';
export * from './events';
export * from './generic-event-emitter';

22 changes: 22 additions & 0 deletions packages/shared/src/events/provider-event-emitter.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { ManageLogger } from '../logger';
import { EventContext, EventHandler } from './eventing';
import { AnyProviderEvent } from './events';

/**
* Event emitter to be optionally implemented by providers.
* Implemented by @see OpenFeatureEventEmitter.
*/
export interface ProviderEventEmitter<E extends AnyProviderEvent, AdditionalContext extends Record<string, unknown> = Record<string, unknown>>
extends ManageLogger<ProviderEventEmitter<E, AdditionalContext>>
{
// here we use E, to restrict the events a provider can manually emit (PROVIDER_CONTEXT_CHANGED is emitted by the SDK)
emit(eventType: E, context?: EventContext): void;

addHandler(eventType: AnyProviderEvent, handler: EventHandler): void;

removeHandler(eventType: AnyProviderEvent, handler: EventHandler): void;

removeAllHandlers(eventType?: AnyProviderEvent): void;

getHandlers(eventType: AnyProviderEvent): EventHandler[];
}
4 changes: 2 additions & 2 deletions packages/shared/src/provider/provider.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { EvaluationContext } from '../evaluation';
import { AnyProviderEvent, GenericEventEmitter } from '../events';
import { AnyProviderEvent, ProviderEventEmitter } from '../events';
import { Metadata, Paradigm } from '../types';

/**
Expand Down Expand Up @@ -57,7 +57,7 @@ export interface CommonProvider {
* An event emitter for ProviderEvents.
* @see ProviderEvents
*/
events?: GenericEventEmitter<AnyProviderEvent>;
events?: ProviderEventEmitter<AnyProviderEvent>;

/**
* A function used to shut down the provider.
Expand Down
Loading