Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: import fixes to fix e2e tests #471

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

toddbaert
Copy link
Member

Both the server and client e2e tests run fine in the CI, but in some local scenarios the "deep imports" we used were causing issues with module resolution.

I've updated the e2e test to always import from the "top level" instead of the /src sub-directory in the test suite.

@toddbaert toddbaert requested a review from a team as a code owner June 29, 2023 15:46
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #471 (0a9b455) into main (a8703ed) will decrease coverage by 99.48%.
The diff coverage is n/a.

❗ Current head 0a9b455 differs from pull request most recent head 84f0158. Consider uploading reports for the commit 84f0158 to get more accurate results

@@            Coverage Diff            @@
##             main   #471       +/-   ##
=========================================
- Coverage   99.47%      0   -99.48%     
=========================================
  Files          25      0       -25     
  Lines        2496      0     -2496     
  Branches      243      0      -243     
=========================================
- Hits         2483      0     -2483     
+ Misses         13      0       -13     

see 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert
Copy link
Member Author

@jamescarr I'm not 100% sure this will fix your issue locally (I wasn't able to reproduce it) but it might.

@toddbaert toddbaert requested a review from jamescarr June 29, 2023 16:03
@toddbaert toddbaert force-pushed the chore/fix-e2e-bundle-issue branch 2 times, most recently from ddcadd2 to 0a9b455 Compare June 29, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants