chore: expose transaction context propagation to the server sdk only #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think there's a way to do this other than manually editing the release PR, so that's the way I'd handle this. It wouldn't be hard - just manual changes to the PR description, the release notes, and the version number. |
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
force-pushed
the
move-request-context
branch
from
f682ff4
to
223ba46
Compare
|
Hey @toddbaert @lukas-reining @thomaspoignant could one of you take a look at this PR when you have a moment? |
lukas-reining
approved these changes
Oct 24, 2023
toddbaert
reviewed
Oct 24, 2023
Comment on lines
+101
to
+103
| , | ||
| "../server/src/transaction-context" | ||
| ], |
There was a problem hiding this comment.
Sorry I'm late to this PR, but I'm a bit confused by this.
It seems odd (and maybe even problematic?) that we need to compile source from server in shared.
This was referenced Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Notes
Transaction context propagation only makes sense on the server and was simply ignored by the client. This removes the methods from the client sdk to avoid confusion.
This is a breaking change in the web SDK. However, it's sub 1.0 and this feature effectively had no effect if it was used. Currently, this is not marked as a breaking change to avoid releasing a major version. @toddbaert do you know if it's possible to mark the server sdk changes as a chore and the web sdk changes as a breaking fix?
Signed-off-by: Michael Beemer [email protected]