-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handlers should run immediately #701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* web-sdk handlers should run immediately if provider in matching state * added tests for both server and client Signed-off-by: Todd Baert <[email protected]>
toddbaert
requested review from
beeme1mr,
Kavindu-Dodan,
thomaspoignant and
lukas-reining
November 30, 2023 18:28
toddbaert
commented
Nov 30, 2023
toddbaert
commented
Nov 30, 2023
lukas-reining
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
beeme1mr
approved these changes
Dec 1, 2023
This was referenced Dec 1, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
🤖 I have created a release *beep* *boop* --- ## [0.4.8](web-sdk-v0.4.7...web-sdk-v0.4.8) (2023-12-08) ### ✨ New Features * ability to get current provider state ([#703](#703)) ([5be715e](5be715e)) * add evaluation context management to the web SDK ([#704](#704)) ([95524f4](95524f4)) ### 🐛 Bug Fixes * handlers should run immediately ([#701](#701)) ([dba858b](dba858b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
🤖 I have created a release *beep* *boop* --- ## [1.7.5](server-sdk-v1.7.4...server-sdk-v1.7.5) (2023-12-08) ### 🐛 Bug Fixes * handlers should run immediately ([#701](#701)) ([dba858b](dba858b)) * type support for Promise<void> before hook ([#693](#693)) ([0b9ca18](0b9ca18)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
toddbaert
pushed a commit
that referenced
this pull request
Jan 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.8](web-sdk-v0.4.7...web-sdk-v0.4.8) (2023-12-08) ### ✨ New Features * ability to get current provider state ([#703](#703)) ([5be715e](5be715e)) * add evaluation context management to the web SDK ([#704](#704)) ([95524f4](95524f4)) ### 🐛 Bug Fixes * handlers should run immediately ([#701](#701)) ([dba858b](dba858b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
toddbaert
added a commit
that referenced
this pull request
Jan 11, 2024
🤖 I have created a release *beep* *boop* --- ## [1.7.5](server-sdk-v1.7.4...server-sdk-v1.7.5) (2023-12-08) ### 🐛 Bug Fixes * handlers should run immediately ([#701](#701)) ([dba858b](dba858b)) * type support for Promise<void> before hook ([#693](#693)) ([0b9ca18](0b9ca18)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #700