Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handlers should run immediately #701

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: handlers should run immediately #701

merged 1 commit into from
Dec 1, 2023

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Nov 30, 2023

  • web-sdk handlers should run immediately if provider in matching state
  • added tests for both server and client

Fixes: #700

* web-sdk handlers should run immediately if provider in matching state
* added tests for both server and client

Signed-off-by: Todd Baert <[email protected]>
Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@beeme1mr beeme1mr added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit dba858b Dec 1, 2023
8 checks passed
@beeme1mr beeme1mr deleted the fix/client-run-now branch December 1, 2023 17:13
github-merge-queue bot pushed a commit that referenced this pull request Dec 8, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.4.8](web-sdk-v0.4.7...web-sdk-v0.4.8)
(2023-12-08)


### ✨ New Features

* ability to get current provider state
([#703](#703))
([5be715e](5be715e))
* add evaluation context management to the web SDK
([#704](#704))
([95524f4](95524f4))


### 🐛 Bug Fixes

* handlers should run immediately
([#701](#701))
([dba858b](dba858b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.7.5](server-sdk-v1.7.4...server-sdk-v1.7.5)
(2023-12-08)


### 🐛 Bug Fixes

* handlers should run immediately
([#701](#701))
([dba858b](dba858b))
* type support for Promise&lt;void&gt; before hook
([#693](#693))
([0b9ca18](0b9ca18))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
toddbaert pushed a commit that referenced this pull request Jan 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.4.8](web-sdk-v0.4.7...web-sdk-v0.4.8)
(2023-12-08)


### ✨ New Features

* ability to get current provider state
([#703](#703))
([5be715e](5be715e))
* add evaluation context management to the web SDK
([#704](#704))
([95524f4](95524f4))


### 🐛 Bug Fixes

* handlers should run immediately
([#701](#701))
([dba858b](dba858b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
toddbaert added a commit that referenced this pull request Jan 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.7.5](server-sdk-v1.7.4...server-sdk-v1.7.5)
(2023-12-08)


### 🐛 Bug Fixes

* handlers should run immediately
([#701](#701))
([dba858b](dba858b))
* type support for Promise&lt;void&gt; before hook
([#693](#693))
([0b9ca18](0b9ca18))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] client handlers do not run immediately if associated provider is in matching state.
3 participants