feat: suspend on RECONCILING, mem provider fixes #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
requested review from
beeme1mr,
kinyoklion,
fabriziodemaria,
luizgribeiro,
lukas-reining and
thomaspoignant
toddbaert
force-pushed
the
feat/suspend-on-stale
branch
from
0de130a
to
0f15280
Compare
toddbaert
force-pushed
the
feat/suspend-on-stale
branch
from
0f15280
to
758a78b
Compare
toddbaert
commented
Jan 30, 2024
toddbaert
commented
Jan 30, 2024
packages/client/src/provider/in-memory-provider/in-memory-provider.ts
Outdated
Show resolved
Hide resolved
beeme1mr
reviewed
Jan 30, 2024
packages/client/src/provider/in-memory-provider/in-memory-provider.ts
Outdated
Show resolved
Hide resolved
packages/client/src/provider/in-memory-provider/in-memory-provider.ts
Outdated
Show resolved
Hide resolved
beeme1mr
approved these changes
Jan 30, 2024
jonathannorris
approved these changes
Jan 30, 2024
toddbaert
force-pushed
the
feat/suspend-on-stale
branch
2 times, most recently
from
f17531a
to
738d6ac
Compare
toddbaert
commented
Mar 1, 2024
toddbaert
changed the title
* Adds suspend on STALE while context changes * Improves event semantics for in-memory provider Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
feat/suspend-on-stale
branch
from
6aac755
to
9d7fd6c
Compare
This was referenced Mar 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.14](web-sdk-v0.4.13...web-sdk-v0.4.14) (2024-03-05) ### ✨ New Features * maintain state in SDK, add RECONCILING ([#795](#795)) ([cfb0a69](cfb0a69)) * suspend on RECONCILING, mem provider fixes ([#796](#796)) ([8101ff1](8101ff1)) ### 🐛 Bug Fixes * allow iteration over all event types ([#844](#844)) ([411c7b4](411c7b4)) * correct rollup to bundle all but core ([#846](#846)) ([f451e25](f451e25)) ### 🧹 Chore * **main:** release core 0.0.27 ([#839](#839)) ([ccbb1f9](ccbb1f9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
toddbaert
pushed a commit
that referenced
this pull request
Mar 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.1-experimental](react-sdk-v0.2.0-experimental...react-sdk-v0.2.1-experimental) (2024-03-05) ### ✨ New Features * maintain state in SDK, add RECONCILING ([#795](#795)) ([cfb0a69](cfb0a69)) * suspend on RECONCILING, mem provider fixes ([#796](#796)) ([8101ff1](8101ff1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds "suspend on reconciling" to the React SDK, in a manner consistent with this spec.
When the SDK emits a PROVIDER_RECONCILING event, loaders are displayed until the CONTEXT_CHANGED event is emitted.