Simplify OFREP OpenAPI Definition #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <[email protected]>
| @@ -11,9 +11,11 @@ security: | |||
| - ApiKeyAuth: [] | |||
| - BearerAuth: [] | |||
| paths: | |||
| /ofrep/v1/evaluate/{key}: | |||
| /ofrep/v1/flags/{key}: | |||
There was a problem hiding this comment.
The proposal in the comment was to use /ofrep/v1/evaluate/flags.
I've already edited the other branch with the proposal.
There was a problem hiding this comment.
I'm fine with that too 👍
There was a problem hiding this comment.
How necessary do we think /ofrep/ is?
There was a problem hiding this comment.
You have a discussion about that in the other PR.
We added /ofrep/ to avoid any collision with existing v1 that can exist in other systems
|
Closing this PR to avoid potential confusion. We'll still be able to use it as a reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Notes
This is a simplified version of the current proposal. I believe, in this case, less is more. It tends to be much easier to add new functionality than to change something. In my opinion, we should defer ETag and caching behavior until after we have the basics in place. I believe this proposal will work well when using both static and dynamic paradigms.