Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add multi provider appendix #264

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

ajwootto
Copy link
Contributor

This PR

  • Adds an appendix section for the Multi-Provider, describing its purpose and implementation

@ajwootto ajwootto force-pushed the multi-provider-index branch 3 times, most recently from 77eba85 to 8175df3 Compare June 10, 2024 17:23
@ajwootto ajwootto marked this pull request as ready for review June 10, 2024 17:25
@ajwootto ajwootto requested a review from toddbaert as a code owner June 10, 2024 17:25
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please put each sentence on its own line? it makes reviews a bit easier.

specification/appendix-d-multi-provider.md Outdated Show resolved Hide resolved
specification/appendix-d-multi-provider.md Outdated Show resolved Hide resolved
specification/appendix-d-multi-provider.md Outdated Show resolved Hide resolved
@toddbaert
Copy link
Member

toddbaert commented Jun 10, 2024

I would recommend we add this to included-utilities, since to me that's what this is.

@beeme1mr @Kavindu-Dodan @lukas-reining @thomaspoignant what do you guys think? Should this be separate?

@lukas-reining
Copy link
Member

I would recommend we add this to included-utilities, since to me that's what this is.

@beeme1mr @Kavindu-Dodan @lukas-reining @thomaspoignant what do you guys think? Should this be separate?

Yes, I also thought about this in the initial discussion @toddbaert.
I would like if it was there as is fits great!
The only question I have is how to fit it in there as it is quite large.

Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, I would just prefer to have this as a subpage or something else of Appendix A: Included Utilities.

Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really well written 🙌

I would recommend we add this to included-utilities, since to me that's what this is.

@toddbaert Given the length and the amount of details of this section, I think this deserves its own section. We could cross link from appendix-a to this (appendix-d) with a short description, similar to Appendix B: Gherkin Suites

@toddbaert
Copy link
Member

I would recommend we add this to included-utilities, since to me that's what this is.
@beeme1mr @Kavindu-Dodan @lukas-reining @thomaspoignant what do you guys think? Should this be separate?

Yes, I also thought about this in the initial discussion @toddbaert. I would like if it was there as is fits great! The only question I have is how to fit it in there as it is quite large.

I think it's fine just to have it as another heading. We can add some collapsible sections if we want.

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve in spirit, but I would like to see this in the included utils. I found a few small nits as well.

Overall very well-written and clear, nice work.

@ajwootto ajwootto force-pushed the multi-provider-index branch 2 times, most recently from 4560a1e to 11bd265 Compare June 12, 2024 20:32
@ajwootto
Copy link
Contributor Author

@toddbaert I moved it to the appendix A section, how's it look in there?

@toddbaert
Copy link
Member

@toddbaert I moved it to the appendix A section, how's it look in there?

@ajwootto looks great! I can't edit your branch, so I've made a small PR which fixes the lint errors: DevCycleHQ-Sandbox#1. Please merge this into your branch and I'll then merge this PR.

ajwootto and others added 3 commits June 18, 2024 11:06
@toddbaert toddbaert changed the title add multi provider appendix chore: add multi provider appendix Jun 18, 2024
@toddbaert
Copy link
Member

Thanks!

@toddbaert toddbaert merged commit eaa44da into open-feature:main Jun 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants