Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace some pngs with mermaid #272

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Sep 24, 2024

Just replaces some PNGs with mermaid.

This is nice because they can change color for the website, and they are more rigorous and maintainable (we already use mermaid in the spec).

old:

image

new:

flowchart LR
    A[Application] --> API(Evaluation API)
    API --> P[Provider]
    P --> FMS[(Flag Management System)]
Loading

image

flowchart LR
    B(('Before' stage)) ---> FE[Flag Evaluation]
    B -..->|Error| E
    FE ---> A(('After' stage))
    FE -..->|Error| E(('Error' stage))
    A ---> F(('Finally' stage))
    E -..-> F
Loading

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, good change!

@toddbaert toddbaert merged commit 807c0d2 into main Sep 24, 2024
5 checks passed
@toddbaert toddbaert deleted the chore/replace-pngs-with-mermaid branch September 24, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants