Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra validations for selectboxes, select and radio #54

Closed
sergei-maertens opened this issue Nov 20, 2023 · 2 comments
Closed

Extra validations for selectboxes, select and radio #54

sergei-maertens opened this issue Nov 20, 2023 · 2 comments

Comments

@sergei-maertens
Copy link
Member

Context: #53 (comment)

Currently you can add manual options/values with:

  • duplicated values, which is confusing when mapping back from values to labels (confirmation, summary...)
  • spaces, periods or other special characters in the values, which is normally okay but makes lookups by value odd (like selectboxes' weird datastructure would probably result in a nested object instead of using the literal key with period in it) and also notably makes processing those values in the Django template engine hard in the backend.

It is verified that Formio itself in its own builder does not validate these things, so if we change the behaviour, then it will be an additional constraint. We will also have to check for existing form definitions that would suddenly become invalid and prevent updating/saving the form again, so we need to be careful about this.

@sergei-maertens
Copy link
Member Author

sergei-maertens commented Dec 18, 2023

open-formulieren/open-forms#3668 -> the value must be able to take on any value, it should not be slug validated.

behaviour is now locked in with a test: b01c0e1

@sergei-maertens
Copy link
Member Author

Not worth the effort at this stage.

@sergei-maertens sergei-maertens closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant