Implement the builder form for the selectboxes component #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
force-pushed
the
feature/52-selectboxes-component
branch
from
3b8668c
to
fee85ae
Compare
sergei-maertens
commented
Nov 15, 2023
sergei-maertens
commented
Nov 15, 2023
| } = useFormikContext<T>(); | ||
| return ( | ||
| <> | ||
| <ValuesSrc /> |
There was a problem hiding this comment.
best would be to pass an onChange here so that we can reset the appropriate field.
There was a problem hiding this comment.
I tried that and it leads to race conditions, so I'm now using useLayoutEffect instead.
There might be an option to use React 18's flushSync instead, but the builder & backend are still stuck on React 17 currently :(
sergei-maertens
commented
Nov 15, 2023
sergei-maertens
commented
Nov 15, 2023
sergei-maertens
force-pushed
the
feature/52-selectboxes-component
branch
from
6184b95
to
e1f380d
Compare
sergei-maertens
commented
Nov 16, 2023
sergei-maertens
force-pushed
the
feature/52-selectboxes-component
branch
2 times, most recently
from
201c878
to
eb8abbd
Compare
sergei-maertens
commented
Nov 16, 2023
sergei-maertens
commented
Nov 16, 2023
Viicos
reviewed
Nov 16, 2023
sergei-maertens
force-pushed
the
feature/52-selectboxes-component
branch
2 times, most recently
from
7e522cd
to
d5a2697
Compare
This component is to be used in the builder preview pane and to set the defaultValue for the SelectBoxes inside the builder edit form.
This was originally planned to use for the itemsExpression in the selectboxes component, but turned out to not be easy to manage to validate for valid JSON and eventually replaced with the already existing (courtesy of Laurens) JSONEdit component. Since we need to eventually implement the TextArea builder component anyway, it will be of good use later and was decided to keep it.
The ArrayField helper that is included in Formik can cause the errors array to contain 'undefined' when re-ordering items. This is unfortunately something outside of our control so it's best to just ignore this situation - knowing where it comes from lets me sleep at night.
This was an (unsuccesful) attempt to make userEvent.click(submitButton) actually submit the form(s) on Firefox, but it is bugged in testing library itself, see: testing-library/user-event#1075
Rather than setting the entire form field values state, it now allows setting a particular field value. This is required for the itemsExpression field in SelectBoxes component.
The filenames have been updated for consistency with other module names and the stories are now grouped under a folder 'values' since there will be more functionality added to values.
The selected mode determines the related inputs to configure the available options for a field with options.
Implemented as a minimal textarea which accepts (and sort-of validates) JSON input, this field will be used to enter the JsonLogic expression when values are to be retrieved dynamically from a variable.
The component manages the (form) state depending on the selected data source for field options/values and renders the appropriate dependent input: * manual -> use the values table so users can enter their options * variable -> use the JSON edit component to set the expression Additionally, it makes sure to clear the state of the 'other' field when a particular data source is selected, as the data model is essentially a discriminated union, which is then processed by the backend.
When manual values are available, they are rendered as is and their default value is taken into account. When the variable data source is specified, a single option is rendered to at least inform the form builder of the expression being used. In the future, we can possibly provide a 'variable' box so that they can try out the preview with a realistic form variable state.
The selectboxes now allows specifying the values, either manually or through an items expression. The labels of options can be translated on the translations tab.
When specifying values manually, the form builder enforces accessible practices in the value/label of each option. There are some limitations in the flexibility with zod validation unions and deep discriminators, but the UI currently prevents ending up in those edge case.
sergei-maertens
force-pushed
the
feature/52-selectboxes-component
branch
from
d5a2697
to
4809d36
Compare
SilviaAmAm
reviewed
Nov 20, 2023
Viicos
reviewed
Nov 20, 2023
Viicos
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52
Ho boi this got a lot bigger than I expected...