Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[char_property] Implement *CharProperty traits #89

Merged
merged 4 commits into from
Aug 9, 2017
Merged

[char_property] Implement *CharProperty traits #89

merged 4 commits into from
Aug 9, 2017

Commits on Aug 9, 2017

  1. [char_property] Implement *CharProperty traits 

    Character Properties are of different kinds and shapes, and as UNIC
components grow, we need a better way to be able to categorize them by
their shape, and a way to make sure we have consistent, noncolliding
API for them.

This is the first step into building a CharProperty taxonomy, with as
little as possibly needed to provide the assurances desired.

We hope that the implementation can be improved over time with new
features added to the language. There's already some proposals in this
front. See these discussions for more details:

* [Traits as contract, without changes to call-sites](https://users.rust-lang.org/t/traits-as-contract-without-changes-to-call-sites/11938/11>)

* [RFC: delegation of implementation](rust-lang/rfcs#1406)
    @behnam
    behnam committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    6888740 View commit details
    Browse the repository at this point in the history

  2. [char_property] Add NumericCharProperty

    @behnam
    behnam committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    0a3dd76 View commit details
    Browse the repository at this point in the history

  3. [char_property] Create CharProperty marker

    @behnam
    behnam committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    b2442f9 View commit details
    Browse the repository at this point in the history

  4. [char_property] Drop CharProperty<T>

    @behnam
    behnam committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    617315c View commit details
    Browse the repository at this point in the history