Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roundup() with simulate() #30

Merged
merged 1 commit into from
May 8, 2020
Merged

roundup() with simulate() #30

merged 1 commit into from
May 8, 2020

Conversation

cprotopa
Copy link
Contributor

@cprotopa cprotopa commented May 4, 2020

This pull request adds the 4h shift to the occupancy results occ and occ_m that can be found in the Household simulation results. Previously only the outputs used in the feeder simulation were shifted.
Additionally, the function roundUp(), used to perform this shift, is now executed as part of the simulate() function, to guarantee the correct time shifting also when someone simulates independent households and forgets to roundUp.
roundUp() joins the main outputs, performs the time shift and also deletes some of the detailed results to clear space, e.g. power results separately for lighting and appliances. Normally the latter are not used, but if required an adaptation of the code should be made.

@SilkeVerbruggen
Copy link
Contributor

Seems a good solution to me! Often when I use the model I forget about the fact that the occupancy is not shifted 4 hours.

@cprotopa cprotopa changed the base branch from master to fix-shower-cycles May 8, 2020 16:06
@cprotopa cprotopa changed the base branch from fix-shower-cycles to master May 8, 2020 16:06
@cprotopa cprotopa merged commit a027b76 into master May 8, 2020
@cprotopa cprotopa deleted the roundUpwithSimulate branch May 8, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants