Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] rtmdet_ins_head scale_factor dimensions #11906

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wickeat
Copy link

@wickeat wickeat commented Aug 12, 2024

Motivation

Fix mask resize error encountered when training an RTMDet instance segmentation model, which leads to inaccurate mask predictions. This manifests itself as issues such as reported in #10179, #10273, #11733, #10918, #11314, to name a few examples.

Modification

Switch the scale_factor dimensions (width and height) used when interpolating the mask. This has been done in mmdeploy as indicated in #11230 and suggested in #11840.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2024

CLA assistant check
All committers have signed the CLA.

@wickeat wickeat changed the title Fix rtmdet_ins_head scale_factor dimensions [Fix] rtmdet_ins_head scale_factor dimensions Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants