-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tools] Support respliting data_batch with tag #7641
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #7641 +/- ##
==========================================
+ Coverage 64.92% 64.94% +0.02%
==========================================
Files 348 349 +1
Lines 28323 28338 +15
Branches 4778 4783 +5
==========================================
+ Hits 18389 18405 +16
Misses 8957 8957
+ Partials 977 976 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should resolve conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* support respliting data_batch with tag * add citations * add a unit test * fix lint
* support respliting data_batch with tag * add citations * add a unit test * fix lint
* support respliting data_batch with tag * add citations * add a unit test * fix lint
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Support respliting data_batch with tag.
Modification
Add a function in
mmdet/utils/data_batch.py
which can respliting data_batch with tag, such as 'sup', 'unsup_teacher', and 'unsup_student'.BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist