Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix WIDERFace SSD loss NAN. #9734

Merged
merged 1 commit into from
Feb 7, 2023
Merged

[Fix] Fix WIDERFace SSD loss NAN. #9734

merged 1 commit into from
Feb 7, 2023

Conversation

RangiLyu
Copy link
Member

@RangiLyu RangiLyu commented Feb 7, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

SSD300 requires grad clip to avoid exploding gradients.
Resolve #9542

Modification

Add grad_clip in config.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@RangiLyu RangiLyu added bug Something isn't working v-2.x labels Feb 7, 2023
@RangiLyu RangiLyu mentioned this pull request Feb 7, 2023
Closed
3 tasks
@ZwwWayne ZwwWayne merged commit 831ba64 into open-mmlab:dev Feb 7, 2023
@RangiLyu RangiLyu mentioned this pull request Mar 3, 2023
Merged
papercatnku pushed a commit to papercatnku/mmdetection that referenced this pull request Apr 7, 2023
Squashed commit of the following:
3d13273 
commit e9cae2d
Author: Haian Huang(深度眸) <[email protected]>
Date:   Tue Feb 28 10:17:10 2023 +0800

    Bump version to v2.28.2 (open-mmlab#9820)

commit 6a904c5
Author: RangiLyu <[email protected]>
Date:   Wed Feb 22 14:51:40 2023 +0800

    [Maintain]: Update .owners.yml (open-mmlab#9818)

commit d8d03bf
Author: chenxujun <[email protected]>
Date:   Sun Feb 19 21:45:08 2023 +0800

    [Doc]: update customize_runtime.md (open-mmlab#9797)

commit 56a3485
Author: Ginray <[email protected]>
Date:   Fri Feb 17 18:42:34 2023 +0800

    [Doc] Fix the configuration file and log path of centernet. (open-mmlab#9791)

commit 0379d4d
Author: vansin <[email protected]>
Date:   Thu Feb 16 09:55:56 2023 +0800

    [Doc]: Add twitter discord medium youtube link (open-mmlab#9774)

commit 831ba64
Author: RangiLyu <[email protected]>
Date:   Tue Feb 7 20:02:56 2023 +0800

    [Fix] Fix WIDERFace SSD loss NAN. (open-mmlab#9734)

commit e7cedcd
Author: RangiLyu <[email protected]>
Date:   Mon Feb 6 20:38:57 2023 +0800

    [Doc]: fix readthedoc (open-mmlab#9729)
thmegy pushed a commit to thmegy/mmdetection that referenced this pull request May 5, 2023
@RangiLyu
[Fix] Fix WIDERFace SSD loss NAN. (open-mmlab#9734)
f43a05e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhaAndroid hhaAndroid hhaAndroid approved these changes

@BIGWangYuDong BIGWangYuDong Awaiting requested review from BIGWangYuDong

Assignees

@hhaAndroid hhaAndroid

Labels
bug Something isn't working v-2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RangiLyu @hhaAndroid @ZwwWayne