Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix piece_expected_num in IoUNegPiecewiseSampler #2017

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

oyel
Copy link
Contributor

@oyel oyel commented Nov 11, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix #2004

Modification

update piece_expected_num iou_neg_piecewise_sampler.py

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@JingweiZhang12
Copy link
Contributor

LGTM. I also fix the lint.

@JingweiZhang12 JingweiZhang12 changed the title [fix] Update piece_expected_num in iou_neg_piecewise_sampler.py [Fix] Fix piece_expected_num in IoUNegPiecewiseSampler Nov 17, 2022
@JingweiZhang12 JingweiZhang12 merged commit b29be44 into open-mmlab:dev-1.x Nov 17, 2022
@oyel oyel deleted the dev-1.x branch November 25, 2022 10:10
ZwwWayne pushed a commit to ZwwWayne/mmdetection3d that referenced this pull request Dec 3, 2022
ZwwWayne pushed a commit to ZwwWayne/mmdetection3d that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants