Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix in-place operator in RAFT #252

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

Zachary-66
Copy link
Collaborator

Motivation

In Issue #248, there is a bug when fine-tuning RAFT, which is caused by an inappropriate in-place operator. This PR aims to fix this bug.

Modification

mmflow/models/utils/res_layer.py

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 68.80% // Head: 69.02% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (44a611e) compared to base (99154a1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   68.80%   69.02%   +0.22%     
==========================================
  Files          92       93       +1     
  Lines        5148     5195      +47     
  Branches      733      741       +8     
==========================================
+ Hits         3542     3586      +44     
- Misses       1491     1495       +4     
+ Partials      115      114       -1     
Flag Coverage Δ
unittests 69.02% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmflow/models/decoders/raft_decoder.py 93.71% <ø> (ø)
mmflow/models/utils/attention1d.py 100.00% <100.00%> (ø)
mmflow/models/utils/res_layer.py 95.29% <100.00%> (ø)
mmflow/version.py 61.53% <100.00%> (ø)
mmflow/datasets/pipelines/transforms.py 78.66% <0.00%> (-0.67%) ⬇️
mmflow/utils/misc.py 100.00% <0.00%> (+4.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng merged commit e2d907c into open-mmlab:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants