-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support GLIP #1308
[Feature] Support GLIP #1308
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev #1308 +/- ##
==========================================
+ Coverage 84.37% 85.17% +0.80%
==========================================
Files 142 230 +88
Lines 9925 17492 +7567
Branches 1621 2742 +1121
==========================================
+ Hits 8374 14899 +6525
- Misses 1277 2079 +802
- Partials 274 514 +240
Flags with carried forward coverage won't be shown. Click here to find out more. see 372 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Are you intend to use the GLIP swin backbone as the pretrained model in classification? It seems like the original paper does not attempt such classification task, but more for detection. Have you done some experiments to prove its performance, otherwise it seems unnecessary to support extra pretrains of swin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Motivation
code: https://github.com/microsoft/GLIP
paper: https://arxiv.org/abs/2112.03857
Checklist
Before PR:
After PR: