Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support GLIP #1308

Merged
merged 6 commits into from
Apr 17, 2023
Merged

[Feature] Support GLIP #1308

merged 6 commits into from
Apr 17, 2023

Conversation

okotaku
Copy link
Collaborator

@okotaku okotaku commented Jan 11, 2023

Motivation

code: https://github.com/microsoft/GLIP
paper: https://arxiv.org/abs/2112.03857

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.80 🎉

Comparison is base (c9a0cb0) 84.37% compared to head (67edd21) 85.17%.

❗ Current head 67edd21 differs from pull request most recent head fb768d5. Consider uploading reports for the commit fb768d5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1308      +/-   ##
==========================================
+ Coverage   84.37%   85.17%   +0.80%     
==========================================
  Files         142      230      +88     
  Lines        9925    17492    +7567     
  Branches     1621     2742    +1121     
==========================================
+ Hits         8374    14899    +6525     
- Misses       1277     2079     +802     
- Partials      274      514     +240     
Flag Coverage Δ
unittests 85.17% <ø> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 372 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ezra-Yu Ezra-Yu requested a review from yingfhu February 16, 2023 02:46
@yingfhu
Copy link
Collaborator

yingfhu commented Feb 17, 2023

Are you intend to use the GLIP swin backbone as the pretrained model in classification? It seems like the original paper does not attempt such classification task, but more for detection. Have you done some experiments to prove its performance, otherwise it seems unnecessary to support extra pretrains of swin

@okotaku okotaku closed this Mar 2, 2023
@Ezra-Yu Ezra-Yu reopened this Apr 11, 2023
@Ezra-Yu Ezra-Yu changed the base branch from dev-1.x to main April 11, 2023 03:38
@Ezra-Yu Ezra-Yu changed the base branch from main to dev April 13, 2023 10:52
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Ezra-Yu Ezra-Yu merged commit fec3da7 into open-mmlab:dev Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants