Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add GQA #1585

Merged
merged 9 commits into from
May 23, 2023
Merged

[Feature]: Add GQA #1585

merged 9 commits into from
May 23, 2023

Conversation

YuanLiuuuuuu
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@YuanLiuuuuuu YuanLiuuuuuu requested a review from mzr1996 May 22, 2023 11:24
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 11.30% and project coverage change: -0.99 ⚠️

Comparison is base (f9dcae2) 68.16% compared to head (35cca5b) 67.18%.

❗ Current head 35cca5b differs from pull request most recent head 209058c. Consider uploading reports for the commit 209058c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1585      +/-   ##
==========================================
- Coverage   68.16%   67.18%   -0.99%     
==========================================
  Files         295      301       +6     
  Lines       23372    23811     +439     
  Branches     3713     3774      +61     
==========================================
+ Hits        15932    15997      +65     
- Misses       6880     7252     +372     
- Partials      560      562       +2     
Flag Coverage Δ
unittests 67.18% <11.30%> (-0.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpretrain/datasets/__init__.py 72.22% <0.00%> (-2.07%) ⬇️
mmpretrain/datasets/gqa_dataset.py 0.00% <0.00%> (ø)
mmpretrain/datasets/scienceqa.py 0.00% <ø> (ø)
mmpretrain/models/multimodal/__init__.py 40.00% <0.00%> (-4.45%) ⬇️
...retrain/models/multimodal/chinese_clip/__init__.py 0.00% <0.00%> (ø)
mmpretrain/models/multimodal/chinese_clip/bert.py 0.00% <0.00%> (ø)
...ain/models/multimodal/chinese_clip/chinese_clip.py 0.00% <0.00%> (ø)
mmpretrain/models/multimodal/chinese_clip/utils.py 0.00% <0.00%> (ø)
mmpretrain/models/utils/__init__.py 83.33% <0.00%> (ø)
mmpretrain/models/utils/tokenizer.py 0.00% <0.00%> (ø)
... and 7 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@YuanLiuuuuuu YuanLiuuuuuu requested a review from mzr1996 May 23, 2023 02:42
@mzr1996 mzr1996 merged commit 46a523e into open-mmlab:dev May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants