Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_make_group_parser for depthwise #177

Open
NickYangMin opened this issue Jun 8, 2022 · 3 comments · Fixed by #195
Open

find_make_group_parser for depthwise #177

NickYangMin opened this issue Jun 8, 2022 · 3 comments · Fixed by #195
Assignees
Labels
bug Something isn't working

Comments

@NickYangMin
Copy link
Contributor

Describe the bug

def find_make_group_parser(self, node_name, name2module):
    """Find the corresponding make_group_parser according to the
    ``node_name``"""
    if 'concat' in node_name and node_name not in name2module:
        return MAKE_GROUP_PARSER_DICT['concat']
    elif 'chunk' in node_name and node_name not in name2module:
        return MAKE_GROUP_PARSER_DICT['chunk']
    elif (node_name in name2module
          and isinstance(name2module[node_name], nn.Conv2d)
          and name2module[node_name].in_channels
          == name2module[node_name].groups):
        return MAKE_GROUP_PARSER_DICT['depthwise']
    else:
        return MAKE_GROUP_PARSER_DICT['common']

if in_channels is 1,there may be a mistake

@NickYangMin NickYangMin added the bug Something isn't working label Jun 8, 2022
@HIT-cwh
Copy link
Collaborator

HIT-cwh commented Jun 15, 2022

I'm sorry for the late reply and the inconvenience to you.
You are right, and in_channels, out_channels and groups should be all the same in depth-wise conv.
Are you interested in making a PR to fix this bug?

@NickYangMin
Copy link
Contributor Author

I do not know How to do it, is there any manual?

@HIT-cwh
Copy link
Collaborator

HIT-cwh commented Jun 23, 2022

@pppppM pppppM linked a pull request Jul 8, 2022 that will close this issue
humu789 pushed a commit to humu789/mmrazor that referenced this issue Feb 13, 2023
* enhance ppl for all codebases

* fix dump info

* fix md and use not None

* remove redundant codes

* safe convert empty ppl tensor

* add examples and remove useless lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants