Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configury: harden IGNORE_TKR check #12707

Draft
wants to merge 1 commit into
base: v4.1.x
Choose a base branch
from

Conversation

ggouaillardet
Copy link
Contributor

@ggouaillardet ggouaillardet commented Jul 24, 2024

NVIDIA HPC Compiler (e.g. nvfortran) incorrectly selected the GCC style pragmas to support IGNORE_TKR. Harden the test by mimicking exactly the mpi f08 bindings in order to fix that false positive.

Thanks Chris Parrot for the report.

Refs. #11582

Signed-off-by: Gilles Gouaillardet [email protected]
bot:notacherrypick
(back-ported from commit 600df6a)

Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

5660c69: configury: harden IGNORE_TKR check

  • check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@ggouaillardet ggouaillardet force-pushed the topic/v4.1.x/nvfortran_ignore_tkr branch from 5660c69 to 194d8a5 Compare July 24, 2024 04:21
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

194d8a5: configury: harden IGNORE_TKR check

  • check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@ggouaillardet
Copy link
Contributor Author

:bot:retest

@wenduwan
Copy link
Contributor

bot:aws:retest

NVIDIA HPC Compiler (e.g. nvfortran) incorrectly selected the GCC
style pragmas to support IGNORE_TKR. Harden the test by mimicking
exactly the mpi f08 bindings in order to fix that false positive.

Thanks Chris Parrot for the report.

Refs. open-mpi#11582

Signed-off-by: Gilles Gouaillardet <[email protected]>
bot:notacherrypick
(back-ported from commit 600df6a)
@ggouaillardet ggouaillardet force-pushed the topic/v4.1.x/nvfortran_ignore_tkr branch from 194d8a5 to 903055c Compare July 25, 2024 16:07
@ggouaillardet
Copy link
Contributor Author

Odd...

I updated the PR to fix

ERROR: files left in build directory after distclean:
./check_ignore_tkr.mod

not sure why other branches were happy though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants