Only use old C-style comments in public headers #12811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPI itself does not require C99 or later so we should provide header files that compile with legacy compilers. Signed-off-by: Joseph Schuchart <[email protected]>
lrbison
approved these changes
Sep 18, 2024
|
@lrbison @devreal We should take the new copy -- wholesale -- from upstream. I meant to file a PR about this over this past weekend but didn't get to it. If someone could update this PR to just get a new copy from upstream (and also remove the now-superflouous #define's in opal_portable_platform.h), that would be awesome. |
|
Hey @devreal -- I worked with the gasnet team upstream to get the needed fixes put in there (https://bitbucket.org/berkeleylab/gasnet/pull-requests/543), and then, as an alternative to this PR, I made #12829 here to pull in the new version of portable_platform from upstream at gasnet. |
|
Replaced by #12829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPI itself does not require C99 or later so we should provide header files that compile with legacy compilers.
Fixes #12710