BTL TCP async progress #1491
Merged
BTL TCP async progress #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
force-pushed
the
progress_thread
branch
from
2aff07b
to
a806300
Compare
|
To answer the @jsquyres questions from #1406. The answer is: this patch doesn't modify the default behavior of the TCP BTL, except that it make it thread safe. However, in addition to this, the code add a second execution path that provides support for async progress for the TCP BTL. However, this support has to be enabled via an MCA parameter in order to be activated. |
bosilca
force-pushed
the
progress_thread
branch
from
a806300
to
324e215
Compare
All BTL-only operations (basically all data movements with the exception of the matching operation) can now be handled for the TCP BTL by a progress thread.
Added mca parameter to turn progress thread on/off Add a flag to check if we have btl progress thread. Added macro for ob1 matching lock. Update the AUTHORS file.
Per @jsquyres suggestion remove all trailing spaces. Credit to `sed -i.bak 's/ *$//' */[ch]`.
bosilca
force-pushed
the
progress_thread
branch
from
324e215
to
f69eba1
Compare
|
Do we need btl_tcp_progress_thread asyc progress for correctness or just for progress / throughput? |
|
This is only needed for async progress. This construct is protected behind am MCA parameter, so in order to get async progress one must explicitly ask for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixed known issues with multi-threading support in the TCP BTL and add support for async progress to the same BTL (even when the multi-threading is not enabled). By default the async progress is compiled in (assuming thread support has been discovered during configure) but is disabled. Use the MCA parameter btl_tcp_progress_thread to activate this extra thread and gain async progress.