Remove the enable-heterogeneous config option #2838
Conversation
This commit removes the enable-heterogeneous option. If the user attempts to use this option, configure will print a warning message and error out. Signed-off-by: Nathaniel Graham <[email protected]>
|
Here is the fix without removing the dead code this PR creates. I can modify it to go ahead and remove that code if it is decided that is what is wanted. |
There was a problem hiding this comment.
Per the F2F Jan 2017 meeting, we agree that we're removing this CLI option, and ensuring to print a warning + abort configure if a user specifies it (on the rationale that we can't deliver what the user asked for, so we need to abort and let a human figure it out).
|
@jsquyres @hppritcha Is this ready to be merged? |
|
I believe that @ggouaillardet wanted to retain it and was offering to maintain it - if that is true, then we really shouldn't remove it. |
|
He did. I assumed that Jeff and Howard had seen his comments on issue #2802 and had decided to go ahead with the removal anyways, but if this is not the case, let me know and I can close this. |
|
I think we should go ahead with this PR and when @ggouaillardet fixes existing issues with hetero he can reenable. |
|
@ggouaillardet We talked about this on the telecon this morning, and bottom line is that we will apply our usual policy here: if someone is willing to maintain and test this feature, then no problem leaving it in the code. This probably applies sooner to v2.1 than v2.0.3, but if you can update the support and at least post on the PR your MTT results, then we are content to leave this alive. |
|
@ggouaillardet Do you have plans to fix the heterogeneous support? |
|
Ok. So the intent is definitely to fix heterogeneous -- let's close this PR, then. |
This commit removes the enable-heterogeneous option.
If the user attempts to use this option, configure
will print a warning message and error out.
fixes #2802
Signed-off-by: Nathaniel Graham [email protected]
@hppritcha @jsquyres