mpi/neighbor_allgatherv: fix copy&paste error and add helpers #3863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Punt to 3.0.1 if needed. Do not let this hold anything up. |
| *outdegree = *indegree = nneighbors; | ||
| } else if (OMPI_COMM_IS_DIST_GRAPH(comm)) { | ||
| /* graph */ | ||
| *indegree = comm->c_topo->mtc.dist_graph->indegree; |
There was a problem hiding this comment.
you could use mca_topo_base_dist_graph_neighbors_count() instead
more generally speaking, is there any reason why you invoke these base functions directly instead of using the callbacks
(for example module->topo.dist_graph.dist_graph_neighbors_count())
|
@hjelmn have you and @ggouaillardet come to a consensus on this? we'd like to get this in today or latest tomorrow morning in time for an rc2. |
|
@hppritcha Yes. I need to add one more commit to this then it is good to go. |
This commit adds a helper function to get the inbound and outbound neighbor count and updates the neighbor_allgatherv bindings to use the correct count when checking the input parameters. Fixes open-mpi#2324 Signed-off-by: Nathan Hjelm <[email protected]> (cherry picked from commit 3c0e94a) Signed-off-by: Nathan Hjelm <[email protected]>
This commit removes the communicator topo helper functions in favor of functions in mca/topo/base. Signed-off-by: Nathan Hjelm <[email protected]> (cherry picked from commit 9b702fb) Signed-off-by: Nathan Hjelm <[email protected]>
hjelmn
force-pushed
the
v3.0.x_neighbor_fix
branch
from
24cf097
to
c19d561
Compare
|
ok, should be good now. |
|
bot:ibm:pgi:retest |
|
Sign off checker seems to be confused. Maybe because the commits are doubly signed. |
|
@ggouaillardet please recheck |
ggouaillardet
approved these changes
Jul 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a helper function to get the inbound and outbound
neighbor count and updates the neighbor_allgatherv bindings to use the
correct count when checking the input parameters.
Fixes #2324
Signed-off-by: Nathan Hjelm [email protected]
(cherry picked from commit 3c0e94a)
Signed-off-by: Nathan Hjelm [email protected]