v3.0.x: remove proof of concept use mpi f08 descriptor module #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ggouaillardet, can you review? |
ggouaillardet
approved these changes
Aug 25, 2017
in order to solve an egg and the chicken problem, in which mpiext need mpi-f08-types.mod and/but use-mpi-f08[-desc] needs mpiext, add an extra step - build fortran 2008 modules only - build fortran 2008 mpi extensions - and then build fortran 2008 bindings Fixes open-mpi#3605 Signed-off-by: Gilles Gouaillardet <[email protected]> (cherry picked from commit 2c71c27)
Signed-off-by: Gilles Gouaillardet <[email protected]> (cherry picked from commit dfe7b2b)
so Open MPI can be configure'd with --enable-mpi-f08-subarray-prototype Signed-off-by: Gilles Gouaillardet <[email protected]> (cherry picked from commit 344f000)
This module was always intended to be a proof of concept, and was far from complete. If/when someone implemented F08 descriptor support for the mpi_f08 module, this commit can either be restored or used as reference material. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 791bcee)
jsquyres
force-pushed
the
pr/v3.0.x/remove-proof-of-concept-use-mpi-f08-descriptor-module
branch
from
f455ba9
to
5566b42
Compare
jsquyres
deleted the
pr/v3.0.x/remove-proof-of-concept-use-mpi-f08-descriptor-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's 4 commits here -- the last one is the one that matters. The 3 leading up to it are just to make the cherry-pick of the 4th commit (i.e., the one that matters) trivial.
v3.0.x RMs: do you want this? It's removal of (effectively) dead code.
Could really be done at any time; I just figured I'd PR it to v3.0.x and let you decide the timing.