osc/pt2pt: disable when THREAD_MULITPLE #5200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
changed the title
Per discussion at open-mpi#2614 (comment), do not allow for selection of the OSC PT2PT when creating an MPI RMA window when THREAD_MULTIPLE is active. Print a helpful message and return a not-supported error. Signed-off-by: Howard Pritchard <[email protected]> Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit d0ffd66) Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/disable-osc-pt2pt-for-thread-multiple
branch
from
66bdd3d
to
5b7c866
Compare
|
@gpaulsen confirms that the 2 IBM CIs are falsely stuck -- they just failed to create a gist, and therefore didn't report their results back (thereby leaving the CI in a "pending" state). Geoff created a gist manually: https://gist.github.com/ibm-ompi/5f2d981dd58cb54a072be3fb81aa806c Meaning: IBM CI actually did pass; the "pending" states here are just showing a failure to report back the results correctly. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osc/pt2pt: disable osc/pt2pt with THREAD_MULTIPLE.
Per discussion at #2614 (comment), do not allow for selection of the OSC PT2PT when creating an MPI RMA window when THREAD_MULTIPLE is active. Print a helpful message and return a not-supported error.
Signed-off-by: Howard Pritchard [email protected]
Signed-off-by: Jeff Squyres [email protected]
(cherry picked from commit d0ffd66)
This will be PR'ed to v3.0.x and v3.1.x when merged to master (and will naturally be included in v4.0.x because we haven't branched for it yet).
Fixes #2614.