opal/fifo: fix 128-bit atomic fifo on Power9 #5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsquyres Turns out that Power 9 can support 128-bit compare-exchange. It has LL/SC instructions for reading/writing quad words. |
|
FYI @gpaulsen. Targeted for v3.0.x and v3.1.x. |
|
Our CI is power8, but I think Josh disabled make-check. |
This commit updates the atomic fifo code to fix a consistency issue observed on Power9 systems when builtin atomics are used. The cause was two things: 1) a missing write memory barrier in fifo push, and 2) a read ordering issue when reading the fifo head non-atomically. This commit fixes both issues and appears to correct then inconsistency. Signed-off-by: Nathan Hjelm <[email protected]>
|
@gpaulsen Any news? 😄 |
|
I'll give it a go. |
|
Build and runs fine on power8 and power9, both with RHEL 7.5 and gcc 4.8.5 'make check' reported all PASSES (including opal_fifo). NOTE: mpool_memkind was skipped because configure was not able to build it (no memkind.h at configure time). I assume this is not related to this opal_fifo change. Thanks again @hjelmn |
gpaulsen
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the atomic fifo code to fix a consistency issue
observed on Power9 systems when builtin atomics are used. The cause
was two things: 1) a missing write memory barrier in fifo push, and 2)
a read ordering issue when reading the fifo head non-atomically. This
commit fixes both issues and appears to correct then inconsistency.
Signed-off-by: Nathan Hjelm [email protected]