v3.1.x: configury: add option to disable enable-new-dtags #7050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config/opal_setup_wrappers.m4
Outdated
| @@ -133,7 +133,7 @@ AC_DEFUN([OPAL_SETUP_WRAPPER_INIT],[ | |||
|
|
|||
| AC_MSG_CHECKING([if want wrapper compiler runpath support]) | |||
| AC_ARG_ENABLE([wrapper-runpath], | |||
| [AS_HELP_STRING([--enable-wrapper-runpath], | |||
| [AS_HELP_STRING([--enable--wrapper-runpath], | |||
There was a problem hiding this comment.
are you sure about this?
| @@ -227,12 +227,41 @@ AC_DEFUN([OPAL_SETUP_RUNPATH],[ | |||
| AC_MSG_RESULT([yes (-Wl,--enable-new-dtags)])], | |||
| [AC_MSG_RESULT([no])]) | |||
| AC_LANG_POP([C])]) | |||
| m4_ifdef([project_ompi],[ | |||
| OPAL_LIBTOOL_CONFIG([wl],[wl_fc],[--tag=FC],[]) | |||
| m4_ifdef([project_ompi],[ | |||
There was a problem hiding this comment.
the previous indentation was correct imho
The --enable-new-dtags option for the compiler wrappers is often great, but for some particular install/usage scenarios causes issues. This commit provides a new configury option to use of rpath in the compiler wrappers, but disables the use of --enable-new-dtags in the link line. The new configury option is --enable-wrappers-runpath To disable use of --enable-new-dtags in the wrappers, add --disable-wrappers-runpath to the Open MPI configury line. Fixes open-mpi#1089 Signed-off-by: Howard Pritchard <[email protected]> (cherry picked from commit ebb30c1)
hppritcha
force-pushed
the
topic/pr3506_to_3.1.x
branch
from
db88ba1
to
faf627d
Compare
jsquyres
changed the title
|
actually this was already applied to v3.1.x before it was branched from master. |
|
Ah! Sorry for the false alarm, then... 😦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --enable-new-dtags option for the compiler wrappers is
often great, but for some particular install/usage scenarios
causes issues.
This commit provides a new configury option to use of rpath
in the compiler wrappers, but disables the
use of --enable-new-dtags in the link line.
The new configury option is
--enable-wrappers-runpath
To disable use of --enable-new-dtags in the wrappers, add
--disable-wrappers-runpath
to the Open MPI configury line.
Fixes #1089
Signed-off-by: Howard Pritchard [email protected]
(cherry picked from commit ebb30c1)