forked from open-telemetry/opentelemetry-python-contrib
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus Remote Write Exporter (5/6) #13
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzfaarQureshi
changed the base branch from
master
to
3-prometheus-remote-write
November 23, 2020 20:57
AzfaarQureshi
force-pushed
the
6-prometheus-remote-write
branch
2 times, most recently
from
November 23, 2020 21:59
eba4082
to
9cc2321
Compare
AzfaarQureshi
force-pushed
the
3-prometheus-remote-write
branch
from
November 23, 2020 22:01
b3c8e81
to
dbcb381
Compare
shovnik
force-pushed
the
3-prometheus-remote-write
branch
from
November 24, 2020 20:52
dbcb381
to
0bc715f
Compare
AzfaarQureshi
force-pushed
the
6-prometheus-remote-write
branch
from
November 24, 2020 20:53
9cc2321
to
7068d79
Compare
AzfaarQureshi
changed the title
Prometheus Remote Write Exporter (6/7) [wip]
Prometheus Remote Write Exporter (6/7)
Nov 24, 2020
shovnik
force-pushed
the
3-prometheus-remote-write
branch
from
November 24, 2020 20:58
0bc715f
to
85d35a7
Compare
AzfaarQureshi
changed the base branch from
3-prometheus-remote-write
to
master
November 24, 2020 21:06
AzfaarQureshi
changed the base branch from
master
to
3-prometheus-remote-write
November 24, 2020 21:06
shovnik
force-pushed
the
3-prometheus-remote-write
branch
from
November 24, 2020 21:17
85d35a7
to
ad98cc1
Compare
AzfaarQureshi
force-pushed
the
6-prometheus-remote-write
branch
2 times, most recently
from
November 24, 2020 21:35
06522f2
to
336a076
Compare
shovnik
force-pushed
the
3-prometheus-remote-write
branch
from
November 24, 2020 21:40
ad98cc1
to
09fe5a2
Compare
AzfaarQureshi
force-pushed
the
6-prometheus-remote-write
branch
2 times, most recently
from
November 24, 2020 22:01
67cd647
to
fa258fe
Compare
AzfaarQureshi
changed the title
Prometheus Remote Write Exporter (6/7)
Prometheus Remote Write Exporter (5/6)
Nov 24, 2020
shovnik
force-pushed
the
3-prometheus-remote-write
branch
from
November 24, 2020 22:17
09fe5a2
to
ac5f46f
Compare
AzfaarQureshi
force-pushed
the
6-prometheus-remote-write
branch
from
November 24, 2020 22:23
fa258fe
to
a89bebd
Compare
alolita
approved these changes
Nov 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
# def test_export_valueobserver(self):
# self.meter.register_valueobserver(
# callback=observer_callback,
# name="ram_usage",
# description="ram memory usage",
# unit="1",
# value_type=float,
# )
adding async conversions fixing tox.ini snappy installing snappy c library installing c snappy library before calling tests
AzfaarQureshi
force-pushed
the
6-prometheus-remote-write
branch
from
November 25, 2020 18:13
a89bebd
to
4e99b72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is PR 5/6 of adding a Prometheus Remote Write Exporter in Python SDK and address Issue open-telemetry/opentelemetry-python#1302
Part 1/6
Part 2/6
Part 3/6
Part 4/6
👉 Part 5/6
Part 6/6
Type of change
How Has This Been Tested?
TestValidation
intest_prometheus_remote_write_exporter.py
Does This PR Require a Core Repo Change?
Checklist:
Changelogs have been updated(change logs will be updated when PR 7/7 is merged and the RW exporter is complete)Documentation has been updatedcc- @shovnik, @alolita