Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Remote Write Exporter (5/6) #13

Closed

Conversation

AzfaarQureshi
Copy link

@AzfaarQureshi AzfaarQureshi commented Nov 23, 2020

Description

This is PR 5/6 of adding a Prometheus Remote Write Exporter in Python SDK and address Issue open-telemetry/opentelemetry-python#1302

Part 1/6

  • Adds class skeleton
  • Adds all function signatures

Part 2/6

  • Adds validation of exporter constructor commands
  • Add unit tests for validation

Part 3/6

  • Adds conversion methods from OTel metric types to Prometheus TimeSeries
  • Add unit tests for conversion

Part 4/6

  • Adds methods to export metrics to Remote Write endpoint
  • Add unit tests for exporting

👉 Part 5/6

  • Add docker integration tests

Part 6/6

  • Add README, Design Doc and other necessary documentation.
  • Set up example app

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Added class TestValidation in test_prometheus_remote_write_exporter.py

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated (change logs will be updated when PR 7/7 is merged and the RW exporter is complete)
  • Unit tests have been added
  • Documentation has been updated
    cc- @shovnik, @alolita

@AzfaarQureshi AzfaarQureshi self-assigned this Nov 23, 2020
@AzfaarQureshi AzfaarQureshi changed the base branch from master to 3-prometheus-remote-write November 23, 2020 20:57
@AzfaarQureshi AzfaarQureshi force-pushed the 6-prometheus-remote-write branch 2 times, most recently from eba4082 to 9cc2321 Compare November 23, 2020 21:59
@AzfaarQureshi AzfaarQureshi marked this pull request as ready for review November 24, 2020 20:54
@AzfaarQureshi AzfaarQureshi changed the title Prometheus Remote Write Exporter (6/7) [wip] Prometheus Remote Write Exporter (6/7) Nov 24, 2020
@AzfaarQureshi AzfaarQureshi changed the base branch from 3-prometheus-remote-write to master November 24, 2020 21:06
@AzfaarQureshi AzfaarQureshi changed the base branch from master to 3-prometheus-remote-write November 24, 2020 21:06
@AzfaarQureshi AzfaarQureshi force-pushed the 6-prometheus-remote-write branch 2 times, most recently from 06522f2 to 336a076 Compare November 24, 2020 21:35
@AzfaarQureshi AzfaarQureshi force-pushed the 6-prometheus-remote-write branch 2 times, most recently from 67cd647 to fa258fe Compare November 24, 2020 22:01
@AzfaarQureshi AzfaarQureshi changed the title Prometheus Remote Write Exporter (6/7) Prometheus Remote Write Exporter (5/6) Nov 24, 2020
Copy link

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove
# def test_export_valueobserver(self):
# self.meter.register_valueobserver(
# callback=observer_callback,
# name="ram_usage",
# description="ram memory usage",
# unit="1",
# value_type=float,
# )

adding async conversions

fixing tox.ini snappy

installing snappy c library

installing c snappy library before calling tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants