Do not make rego trace unless --trace flag is passed in #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msarvar amazing catch! Don't forget to sign the DCO. I'll take a look in the meantime :) |
Signed-off-by: Sarvar Muminov <[email protected]>
Signed-off-by: Sarvar Muminov <[email protected]>
Signed-off-by: Sarvar Muminov <[email protected]>
msarvar
force-pushed
the
move-tracing-into-optional
branch
from
96f6434
to
a59dc0c
Compare
|
Fixed the DCO. It was a fun debugging session that involved some stracing and looking up system calls :D |
msarvar
added a commit
to runatlantis/atlantis
that referenced
this pull request
May 13, 2021
Version 0.25.0 solves OOM issue described in [556](open-policy-agent/conftest#556).
msarvar
added a commit
to runatlantis/atlantis
that referenced
this pull request
May 13, 2021
Version 0.25.0 solves OOM issue described in [556](open-policy-agent/conftest#556).
macox
pushed a commit
to macox/conftest
that referenced
this pull request
Oct 5, 2021
…agent#556) * Making tracing functionality optional Signed-off-by: Sarvar Muminov <[email protected]> * Adding tests Signed-off-by: Sarvar Muminov <[email protected]> * Use Trace variable for `verify` command Signed-off-by: Sarvar Muminov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently conftest always uses tracing even if
--traceflag is not used. This is causes significant memory consumption whenconftestis used with a semi complicated rego library and big config files. This is a PR to the #555