Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add parse combine info to index #940

Conversation

amber-beasley-liatrio
Copy link

hoping to provide information that was not trivial/obvious to those newer to rego and conftest

Signed-off-by: Amber Beasley <[email protected]>
Copy link
Member

@jalseth jalseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and keeping our docs up to date! A couple of small changes.

app: hello-kubernetes
```

> To use the builtin functions, you need to include `github.com/open-policy-agent/conftest/builtins` in your Go file import section if you did not include it elsewhere for default go commands configuration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it belongs in a "developer docs" section rather than unit test section. We don't really have a page for that yet, would you mind starting one?


**combine.yaml**

```yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reduce the size of this example to only include the deployment that matches the rule's test?

@jalseth
Copy link
Member

jalseth commented Jul 13, 2024

Hi @amber-beasley-liatrio friendly ping. Are you still working on this?

@jalseth
Copy link
Member

jalseth commented Aug 16, 2024

Closing this due to inactivity. Feel free to reopen if you pick this up again.

@jalseth jalseth closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants