Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels and metadata in audit logs of resource against which audits run #1977

Closed
nishant-ui opened this issue Apr 10, 2022 · 8 comments · Fixed by #2354
Closed

Add labels and metadata in audit logs of resource against which audits run #1977

nishant-ui opened this issue Apr 10, 2022 · 8 comments · Fixed by #2354
Labels
enhancement New feature or request triaged

Comments

@nishant-ui
Copy link

nishant-ui commented Apr 10, 2022

The gatekeeper audit pod should have the functionality to emit labels and more details of the resource against which audit ran.
Currently, we get resource name,namespaceetc. It will be good to add labels of the resource as well.

@nishant-ui nishant-ui added the enhancement New feature or request label Apr 10, 2022
@nishant-ui nishant-ui changed the title Add labels and metadata in audit logs of resource against which violations are created Add labels and metadata in audit logs of resource against which audits run Apr 10, 2022
@maxsmythe
Copy link
Contributor

I wonder if we should log the contents of the violating resource, or add the option to do so.

There may be cases where users wouldn't want certain things logged, like the contents of secrets, so we should be careful how we go about this.

@ritazh
Copy link
Member

ritazh commented Apr 13, 2022

Adding the option to include labels sounds interesting. Adding contents of the resource sounds too broad and can create privacy and security issues. Definitely interested to see how many people want this feature. Please +1 if you want this and please indicate what additional data you need.

@nishant-ui
Copy link
Author

nishant-ui commented Apr 18, 2022

Adding just the labels should be good enough !

@stale
Copy link

stale bot commented Jul 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 23, 2022
@ritazh ritazh added stale and removed wontfix This will not be worked on labels Aug 10, 2022
@stale stale bot removed the stale label Aug 10, 2022
@stale
Copy link

stale bot commented Oct 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Dec 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 26, 2022
@maxsmythe maxsmythe added triaged and removed stale labels Jan 4, 2023
@acpana
Copy link
Contributor

acpana commented Apr 17, 2023

@nishant-ui I reckon davis's #2354 addressed the issue here, right? If so, can we close this issue @maxsmythe ?

@maxsmythe
Copy link
Contributor

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants