-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add resource labels to audit logs #2354
feat: add resource labels to audit logs #2354
Conversation
Signed-off-by: davis-haba <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit, otherwise LGTM!
Thanks @davis-haba !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: davis-haba <[email protected]>
f4c3d02
to
b2a9f43
Compare
Codecov ReportBase: 53.40% // Head: 53.25% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2354 +/- ##
==========================================
- Coverage 53.40% 53.25% -0.16%
==========================================
Files 116 116
Lines 10198 10199 +1
==========================================
- Hits 5446 5431 -15
- Misses 4336 4348 +12
- Partials 416 420 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: davis-haba [email protected]
What this PR does / why we need it:
When logging violations, also log the labels of the violating resource
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1977
Special notes for your reviewer:
Example of violation with labels (note the new
resource_labels
key):