Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constraint status violations are missing the GV in GVK #2095

Closed
ekitson opened this issue Jun 9, 2022 · 1 comment · Fixed by #2098
Closed

Constraint status violations are missing the GV in GVK #2095

ekitson opened this issue Jun 9, 2022 · 1 comment · Fixed by #2098
Labels
bug Something isn't working

Comments

@ekitson
Copy link

ekitson commented Jun 9, 2022

What steps did you take and what happened:
View the status of a constraint with violations. Each violation has a Kind, Namespace, and Name, but no Group or Version.

What did you expect to happen:
Resources are only uniquely identifiable by their GKNN and most API server requests require GVKNN. It would be helpful to fully identify violating resources.

Anything else you would like to add:
This looks like it may be a couple line fix: https://github.com/open-policy-agent/gatekeeper/blob/master/pkg/audit/manager.go#L90

The updateListEntry struct already has the group and version fields, they just aren't being copied over?
@ekitson ekitson added the bug Something isn't working label Jun 9, 2022
prachirp added a commit to prachirp/gatekeeper that referenced this issue Jun 11, 2022
@prachirp
Update manager.go
a89b0e5 
For open-policy-agent#2095
@prachirp prachirp mentioned this issue Jun 13, 2022
Merged
prachirp added a commit to prachirp/gatekeeper that referenced this issue Jun 13, 2022
@prachirp
Update manager.go
2b16216 
For open-policy-agent#2095

Signed-off-by: Prachi Pendse <[email protected]>
sozercan pushed a commit that referenced this issue Jun 14, 2022
@prachirp
fix: #2095 GV in constraint StatusViolation (#2098)
d3e62d0
@julianKatz
Copy link
Contributor

Would be good to update the docs as well

ChrisFraun pushed a commit to ChrisFraun/gatekeeper that referenced this issue Jun 29, 2022
@prachirp @ChrisFraun
fix: open-policy-agent#2095 GV in constraint StatusViolation (open-po…
492efb4 
…licy-agent#2098)

Signed-off-by: Christoph Fraundorfer <[email protected]>
ChrisFraun pushed a commit to ChrisFraun/gatekeeper that referenced this issue Jun 29, 2022
@prachirp @ChrisFraun
fix: open-policy-agent#2095 GV in constraint StatusViolation (open-po…
e6a059c 
…licy-agent#2098)

Signed-off-by: Christoph Fraundorfer <[email protected]>
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this issue Jul 19, 2022
@prachirp @davis-haba
fix: open-policy-agent#2095 GV in constraint StatusViolation (open-po…
dcd6bea 
…licy-agent#2098)

Signed-off-by: davis-haba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #2095 GV in constraint StatusViolation prachirp/gatekeeper
2 participants
@ekitson @julianKatz