revert: Revert "feat: Add extraEnv support to deployments (#2330)" #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sozercan
changed the title
…2330)" This reverts commit cd7bf3f. Signed-off-by: Sertac Ozercan <[email protected]>
sozercan
force-pushed
the
revert-cd7bf3f9e
branch
from
95c96a4
to
87ff685
Compare
sozercan
changed the title
Codecov ReportBase: 53.24% // Head: 53.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2355 +/- ##
==========================================
+ Coverage 53.24% 53.39% +0.14%
==========================================
Files 116 116
Lines 10198 10198
==========================================
+ Hits 5430 5445 +15
+ Misses 4347 4336 -11
+ Partials 421 417 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ritazh
approved these changes
Oct 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cd7bf3f.
What this PR does / why we need it:
Reverting this as env is under
containers, not podSpecW1022 21:23:48.968816 31596 warnings.go:70] unknown field "spec.template.spec.env"Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Related #2330
FYI @madmatt112
Special notes for your reviewer: