Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format: make groupIterable sort by row #3851

Merged
merged 3 commits into from
Oct 4, 2021
Merged

format: make groupIterable sort by row #3851

merged 3 commits into from
Oct 4, 2021

Commits on Oct 4, 2021

  1. format: make groupIterable sort by row 

    Before, it depended on the elements being passed in ordered by their rows.
Before open-policy-agent#3823, the iteration
order was the same as the row order; but with sorting the keys slice (which
determines iteration order) on creation, that was changed.

Now, we'll sort the elements within `groupIterable`.

Fixes open-policy-agent#3849.

Signed-off-by: Stephan Renatus <[email protected]>
    @srenatus
    srenatus committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    84807fa View commit details
    Browse the repository at this point in the history

  2. ast/term_bench_test: fix benchmark 

    Since map iteration is randomized in golang, this benchmark didn't
actually measure what was intended, but rather the presence or ab-
sence of duplicate keys.

Now, we'll create a set of keys to insert before, and either shuffle
it or use it in its increasing order: to call `(Object).Insert()` in
a loop.

Signed-off-by: Stephan Renatus <[email protected]>
    @srenatus
    srenatus committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    0b5a4e7 View commit details
    Browse the repository at this point in the history

  3. CHANGELOG/capabilities: update for v0.33.1 bugfix release 

    Signed-off-by: Stephan Renatus <[email protected]>
    @srenatus
    srenatus committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    5b324c8 View commit details
    Browse the repository at this point in the history