-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update debug build base images to remove openssl #5787
Merged
charlieegan3
merged 1 commit into
open-policy-agent:main
from
charlieegan3:complete-base-image-update
Mar 23, 2023
Merged
Update debug build base images to remove openssl #5787
charlieegan3
merged 1 commit into
open-policy-agent:main
from
charlieegan3:complete-base-image-update
Mar 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
srenatus
approved these changes
Mar 22, 2023
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This completes the work started in #5540 Fixes #5544 We can't use distroless since they don't have a nossl cc image: GoogleContainerTools/distroless#1210 Chainguard have added this (-dev rather than :debug) to their image collection: chainguard-images/images#187 Following advice here, using their busybox is the best replacement for `gcr.io/distroless/static:debug` chainguard-images/images#368 (comment) Signed-off-by: Charlie Egan <[email protected]>
ashutosh-narkar
approved these changes
Mar 22, 2023
@charlieegan3 have you tested if the new images with your changes work similar to the existing ones? |
Hey, I have done the following, let me know if you think we need to do more.
|
Thanks @charlieegan3 ! lgtm. |
Thanks! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the work started in #5540
Fixes #5544
We can't use distroless since they don't have a nossl cc image: GoogleContainerTools/distroless#1210
Chainguard have added this (-dev rather than :debug) to their image collection: chainguard-images/images#187
Following advice here, using their busybox is the best replacement for
gcr.io/distroless/static:debug
chainguard-images/images#368 (comment)