ast: skip if keyword requirement for default rule #6356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashutosh-narkar
force-pushed
the
default-if-req
branch
from
4350cae
to
af55b54
Compare
The `rego.v1` import requires the `if` keyword before the rule body. We should make an exception for default rules. Signed-off-by: Ashutosh Narkar <[email protected]>
ashutosh-narkar
force-pushed
the
default-if-req
branch
from
af55b54
to
f1eb54f
Compare
|
That is indeed a good catch 👍 Although also a little worrying thinking about other possible exceptions that might need to be required? It'd be great if we could test this at larger scale, like targeting our "YAML test" suite or something? Excluding of course anything that's testing things that will be removed with 1.0. Or we're doing something like that and this just wasn't caught? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rego.v1import requires theifkeyword before the rule body. We should make an exception for default rules.