feature(builtins): add a new builtin function to render templated strings #6411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
RDVasavada
force-pushed
the
feature/template-rendering
branch
from
bbdfbfd
to
02236bb
Compare
RDVasavada
changed the title
RDVasavada
force-pushed
the
feature/template-rendering
branch
from
0db7400
to
5c787f1
Compare
ashutosh-narkar
force-pushed
the
feature/template-rendering
branch
from
66f2a9c
to
7e10ee6
Compare
There was a problem hiding this comment.
@RDVasavada thanks for the contribution. Few comments inline.
|
Thanks for your feedback @ashutosh-narkar. I have addressed your comments -- let me know if you have any additional feedback! |
|
@RDVasavada can you please squash your commits and we can get this in. Thanks! |
|
Check this link if you need pointers to craft a good commit message. |
|
Added a unit test for non-string template var inputs and added back the template docs link as requested by @johanfylling, please let me know if there's any other feedback before I squash, thanks! |
RDVasavada
force-pushed
the
feature/template-rendering
branch
2 times, most recently
from
8185718
to
76f6d7c
Compare
|
@ashutosh-narkar rebased and squashed |
RDVasavada
force-pushed
the
feature/template-rendering
branch
from
76f6d7c
to
1417763
Compare
ashutosh-narkar
approved these changes
Nov 17, 2023
… render templated strings This adds support for rendering of templated strings utilizing Golang's text/template library. For a given templated string and key/value mapping of template var inputs, this builtin will inject the values into the template where they are referenced by key. Fixes open-policy-agent#6371 Signed-off-by: Rohan Vasavada <[email protected]>
ashutosh-narkar
force-pushed
the
feature/template-rendering
branch
from
1417763
to
21598e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
closes: #6371
Adds a builtin function for template rendering.
What are the changes in this PR?
Adds a new builtin function that accepts a templated string and a mapping of vars to inject, and returns the rendered string with the vars injected.
Notes to assist PR review:
For this builtin function, I've set the
missingkeyoption toerror, so that if the template contains a variable that is not present in the given variable mapping, the function will not attempt to render the template and return an error. This was done to prevent silent failures from occurring.