sdk_test: add environment variable tests #6420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
previously approved these changes
Nov 17, 2023
sdk/opa_test.go
Outdated
| @@ -2150,6 +2151,150 @@ result := { | |||
| } | |||
| } | |||
|
|
|||
| func TestOpaRuntimeEnvironmentVariableDefinedInOS(t *testing.T) { | |||
| os.Setenv("TOKEN_VERIFY_KEY", "B41BD5F462719C6D6118E673A2389") | |||
|
I updated the commit on my forked branch expecting it to update the PR, but it doesn't look like it did. Is there something else that I need to do for the PR to be updated? |
|
I think I was looking at an outdated compare. I think it looks correct now. |
srenatus
previously approved these changes
Nov 17, 2023
sdk/opa_test.go
Outdated
| defer server.Stop() | ||
|
|
||
| testBundleResource := "/bundles/bundle.tar.gz" | ||
| testLabel := "a label" |
There was a problem hiding this comment.
Is the label relevant to the test? I'd suggest removing it if not... 🤔 Sorry I didn't notice in the last round of reviewing
There was a problem hiding this comment.
No, it's not relevant. I removed it from both tests and updated the PR. Thanks!
Add two environment variable tests which illustrate how an environment variable can be used in OPA to verify a JWT. Signed-off-by: Robert Hafner <[email protected]>
colinjlacy
pushed a commit
to colinjlacy/opa
that referenced
this pull request
Nov 20, 2023
Add two environment variable tests which illustrate how an environment variable can be used in OPA to verify a JWT. Signed-off-by: Robert Hafner <[email protected]> Signed-off-by: Colin Lacy <[email protected]>
colinjlacy
pushed a commit
to colinjlacy/opa
that referenced
this pull request
Nov 22, 2023
Add two environment variable tests which illustrate how an environment variable can be used in OPA to verify a JWT. Signed-off-by: Robert Hafner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two environment variable tests which illustrate how an environment variable can be used in OPA to verify a JWT.
Why the changes in this PR are needed?
What are the changes in this PR?
Notes to assist PR review:
Further comments: