Clarify the specification for include directive #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakhimov
requested review from
mhibti,
AntoineRauzy,
cfolleau,
emelendez-csn,
a user,
MichelBatteux,
friedlhu and
RobertoHerrero
|
@rakhimov You are totally right for Xinclude, Xinclude is XML standard, we should simply use it. For people who don't know what it is: https://www.w3.org/TR/xinclude/#basic-example |
|
Agreed ...
…On 4/20/2017 18:23, Cyrille Folleau wrote:
@rakhimov <https://github.com/rakhimov> You are totally right for
Xinclude, Xinclude is XML standard, we should simply use it.
For people who don't know what it is:
https://www.w3.org/TR/xinclude/#basic-example
I am not for "reinventing the wheel".
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#45 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AXHNMw9y2htweVtsKpCbcYzgZSY4dXPwks5rxyQIgaJpZM4NBYL->.
|
- Explore more alternative options: XInclude and multiple input files - Change the reasoning: portability and convenience (the performance gain is left implicit) - Clarify what "load" means: context-specific, implicit selective query - Clarify the resolution of relative paths - Allow easy automatic validation (each to-be-included file must be valid by itself against the schema) Currently, the include directive can appear only in fault-trees, components, model-data, and opsa-mef. Therefore, wording is changed from "anywhere" to "specific places".
|
Closing this in favor of #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(the performance gain is left implicit)
(each to-be-included file must be valid by itself against the schema)
Currently, the include directive can appear only
in fault-trees, components, model-data, and opsa-mef.
Therefore, wording is changed from "anywhere" to "specific places".
Closes #16