Update validation docs + minor validation bug fix #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
connorcoley
commented
Jun 25, 2020
connorcoley
commented
- Added multistep-relevant validations to the docs
- Added additional messages that were previously missing from docs
- Fixed minor validation bug where a reaction input couldn't just use a crude component; figured it was minor enough that I didn't need to separate out the PR
- Mostly around multistep chemistry - Caught missing references to new submessages when we changed the schema to stop using the `field`, `field_details` construction and switched to submessages with a `type` and `details`
skearnes
approved these changes
Jun 25, 2020
|
Seeing an error from |
I restarted the jobs; fingers crossed. |
|
Looks like that fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.