ci: use matrix to reduce duplication #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: winstxnhdw <[email protected]>
Signed-off-by: winstxnhdw <[email protected]>
arjo129
approved these changes
May 16, 2024
|
Probably will have to manually merge this then change the branch protection rules afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There's a lot of overlap between the Windows and Linux CI. In that case, it's a lot more idiomatic to use a matrix to reduce duplication and improve the maintainability of the actions. There's also no need to specify the shell type because GitHub Actions default to PowerShell on Windows.
We also cache our dependencies before each build to improve our CI times.
Let me know what you think.