-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/request date export #690
Conversation
… when it has not been created before Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## deploy/hammer #690 +/- ##
=================================================
+ Coverage 59.30% 59.47% +0.16%
=================================================
Files 281 282 +1
Lines 5932 6003 +71
Branches 801 789 -12
=================================================
+ Hits 3518 3570 +52
- Misses 2260 2279 +19
Partials 154 154
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LGTM! |
* Added date column to minimal export, only update fields of task state when it has not been created before Signed-off-by: Aaron Chong <[email protected]> * Use create and get_or_none, and save model if it exists Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit a1ea778) Signed-off-by: Aaron Chong <[email protected]>
* Date column in Tasks section (#689) * Add unix-millis-request-time field in taskstate Signed-off-by: fierro <[email protected]> * Generate taskstate model according to the rmf_api_msgs changes Signed-off-by: fierro <[email protected]> * Generate api client to get the new field Signed-off-by: fierro <[email protected]> * Save unix request time as now() and use previous value if the method is update Signed-off-by: fierro <[email protected]> * Show unix_millis_request_time in dashboard Signed-off-by: fierro <[email protected]> * Add Unix_millis_request_time into booking instead of taskstate directly Signed-off-by: fierro <[email protected]> * Access to unix_millis_request_time field through booking Signed-off-by: fierro <[email protected]> * Get previous task_state and if is not none use its request_time value Signed-off-by: fierro <[email protected]> --------- Signed-off-by: fierro <[email protected]> (cherry picked from commit 7ea986d) Signed-off-by: Aaron Chong <[email protected]> * Fix/request date export (#690) * Added date column to minimal export, only update fields of task state when it has not been created before Signed-off-by: Aaron Chong <[email protected]> * Use create and get_or_none, and save model if it exists Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit a1ea778) Signed-off-by: Aaron Chong <[email protected]> * Feature/task initiator (#692) * Add initiator column in taskstate model Signed-off-by: fierro <[email protected]> * Initiator field has been added on client side Signed-off-by: fierro <[email protected]> * Set initiator field with the previous value if its is updated or use self.user.username if its is created Signed-off-by: fierro <[email protected]> * Add initiator as column in datagrid and show it in TaskSection Signed-off-by: fierro <[email protected]> * Populate initiator field with self.user.name when task is created Signed-off-by: fierro <[email protected]> * Add initiator column to minimal export Signed-off-by: fierro <[email protected]> * Set initiator column to minimal export Signed-off-by: fierro <[email protected]> * In update method, fill the initiator field with the previous db_task_state value Signed-off-by: fierro <[email protected]> --------- Signed-off-by: fierro <[email protected]> (cherry picked from commit 86700da) Signed-off-by: Aaron Chong <[email protected]> * Adding user and request time to requests before submitting Signed-off-by: Aaron Chong <[email protected]> * api-server, use requester instead of initiator for task_request and task_state Signed-off-by: Aaron Chong <[email protected]> * Initiator to Requester Signed-off-by: Aaron Chong <[email protected]> * Update api-client Signed-off-by: Aaron Chong <[email protected]> * Using N/A instead of unknown for fields Signed-off-by: Aaron Chong <[email protected]> * pylint Signed-off-by: Aaron Chong <[email protected]> * Changing N/A to unknown Signed-off-by: Aaron Chong <[email protected]> * Adding try catch for username promise Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: fierro <[email protected]> Signed-off-by: Aaron Chong <[email protected]> Co-authored-by: César Rolón <[email protected]>
What's new
Related to #689
save_task_state
To check exports, go to download button and select minimal export
To check if the request time stays the same, add these lines after here, outside of the else scope
Self-checks