-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/beacons frontend #733
Conversation
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #733 +/- ##
==========================================
- Coverage 54.65% 54.64% -0.02%
==========================================
Files 261 263 +2
Lines 6486 6524 +38
Branches 838 862 +24
==========================================
+ Hits 3545 3565 +20
- Misses 2803 2819 +16
- Partials 138 140 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Aaron Chong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, Aaron!
This code follows the way that we have designed Doors and Lifts tables so I have not any big comments.
I left only one nit comment.
All clean and looks really nice!
import { ApiServerModelsTortoiseModelsBeaconsBeaconStateLeaf as BeaconState } from 'api-client'; | ||
import { DataGrid, GridColDef, GridValueGetterParams, GridCellParams } from '@mui/x-data-grid'; | ||
import { Box, SxProps, Typography, useTheme } from '@mui/material'; | ||
import * as React from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Is there any reason to do this instead of how we do it in the rest of the files (import React from 'react';)?
In fact, we could start by doing import {useState, useEffect, ...} from React to be more specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I copied over from doors and lifts too much, thanks for catching that! 7cd343d fixes it as well as for doors and lifts
@aaronchongth Oh, btw, I don't see the Beacons table in the System Overview tab, is there a reason for that? |
Signed-off-by: Aaron Chong <[email protected]>
@Angatupyry sorry I forgot to answer this, beacons will be rather specific hardware that is not used in any of our demos or use cases for now, so we'll only use them in projects or when we do have beacons in our simulation demos. For projects that use them, I expect the layout will be different anyway |
What's new
simplescreenrecorder-2023-08-08_17.01.41.mp4
Testing
Either
dashboard/src/components/robots/robots-workspace.tsx
to show the beacons micro appSelf-checks