Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display an alert when low display res detected #767

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

aaronchongth
Copy link
Member

What's new

Displays an alert if the display resolution is low.

simplescreenrecorder-2023-09-08_17.13.40.mp4

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #767 (74d5c31) into main (3388e03) will decrease coverage by 0.10%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head 74d5c31 differs from pull request most recent head 4fd5a22. Consider uploading reports for the commit 4fd5a22 to get more accurate results

@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
- Coverage   54.20%   54.11%   -0.10%     
==========================================
  Files         263      263              
  Lines        6593     6605      +12     
  Branches      877      879       +2     
==========================================
  Hits         3574     3574              
- Misses       2879     2891      +12     
  Partials      140      140              
Flag Coverage Δ
dashboard 17.90% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/dashboard/src/components/app-base.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <[email protected]>
Copy link
Collaborator

@Angatupyry Angatupyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, man!
This is so cool!
Just a small comment that doesn't alter the approval.
LGTM!

packages/dashboard-e2e/wdio.conf.js Outdated Show resolved Hide resolved
@aaronchongth aaronchongth merged commit 0d352fe into main Sep 8, 2023
3 checks passed
@aaronchongth aaronchongth deleted the feature/display-res-alert branch September 8, 2023 17:38
aaronchongth added a commit that referenced this pull request Sep 11, 2023
* Display an alert when low display res detected

Signed-off-by: Aaron Chong <[email protected]>

* Raising e2e test resolution

Signed-off-by: Aaron Chong <[email protected]>

* Adding comment about raising testing resolution

Signed-off-by: Aaron Chong <[email protected]>

---------

Signed-off-by: Aaron Chong <[email protected]>
(cherry picked from commit 0d352fe)
Signed-off-by: Aaron Chong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants