-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/save request #842
Merged
Merged
Feature/save request #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
+ Coverage 51.41% 51.51% +0.10%
==========================================
Files 282 282
Lines 7140 7159 +19
Branches 960 960
==========================================
+ Hits 3671 3688 +17
- Misses 3321 3323 +2
Partials 148 148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
aaronchongth
added a commit
that referenced
this pull request
Nov 27, 2023
* New route for saving and getting successfully dispatched requests Signed-off-by: Aaron Chong <[email protected]> * Announce failed to dispatch instead of create task Signed-off-by: Aaron Chong <[email protected]> * Generate api-client Signed-off-by: Aaron Chong <[email protected]> * Use api task request instead of custom ttm pydantic model Signed-off-by: Aaron Chong <[email protected]> * Revert alert text change Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit 52a7d14) Signed-off-by: Aaron Chong <[email protected]>
aaronchongth
added a commit
that referenced
this pull request
Nov 27, 2023
* New route for saving and getting successfully dispatched requests Signed-off-by: Aaron Chong <[email protected]> * Announce failed to dispatch instead of create task Signed-off-by: Aaron Chong <[email protected]> * Generate api-client Signed-off-by: Aaron Chong <[email protected]> * Use api task request instead of custom ttm pydantic model Signed-off-by: Aaron Chong <[email protected]> * Revert alert text change Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit 52a7d14) Signed-off-by: Aaron Chong <[email protected]>
aaronchongth
added a commit
that referenced
this pull request
Nov 28, 2023
* Feature/save request (#842) * New route for saving and getting successfully dispatched requests Signed-off-by: Aaron Chong <[email protected]> * Announce failed to dispatch instead of create task Signed-off-by: Aaron Chong <[email protected]> * Generate api-client Signed-off-by: Aaron Chong <[email protected]> * Use api task request instead of custom ttm pydantic model Signed-off-by: Aaron Chong <[email protected]> * Revert alert text change Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit 52a7d14) Signed-off-by: Aaron Chong <[email protected]> * Regenerating api-client Signed-off-by: Aaron Chong <[email protected]> * Query multiple task requests Signed-off-by: Aaron Chong <[email protected]> * Lint Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]>
aaronchongth
added a commit
that referenced
this pull request
Nov 28, 2023
* Feature/save request (#842) * New route for saving and getting successfully dispatched requests Signed-off-by: Aaron Chong <[email protected]> * Announce failed to dispatch instead of create task Signed-off-by: Aaron Chong <[email protected]> * Generate api-client Signed-off-by: Aaron Chong <[email protected]> * Use api task request instead of custom ttm pydantic model Signed-off-by: Aaron Chong <[email protected]> * Revert alert text change Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit 52a7d14) Signed-off-by: Aaron Chong <[email protected]> * Regenerating api-client Signed-off-by: Aaron Chong <[email protected]> * Passing requests into task data-grid component Signed-off-by: Aaron Chong <[email protected]> * Query multiple task requests Signed-off-by: Aaron Chong <[email protected]> * Query task requests Signed-off-by: Aaron Chong <[email protected]> * Lint Signed-off-by: Aaron Chong <[email protected]> * Parse and display pickup and dropoff Signed-off-by: Aaron Chong <[email protected]> * Parse automated charging task destination using task state Signed-off-by: Aaron Chong <[email protected]> * Task queue table with category as well Signed-off-by: Aaron Chong <[email protected]> * Fix tests Signed-off-by: Aaron Chong <[email protected]> * Export minimal with new columns Signed-off-by: Aaron Chong <[email protected]> * Make requester, pickup and destination not sortable or filterable for now Signed-off-by: Aaron Chong <[email protected]> * Reuse getAllTaskRequests Signed-off-by: Aaron Chong <[email protected]> * Revert reuse as it requires adding dependencies Signed-off-by: Aaron Chong <[email protected]> * Revert category column, as filtering and sorting is convoluted for now Signed-off-by: Aaron Chong <[email protected]> * Added comment regarding not reusing getAllTaskRequests Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Endpoint for saving task requests
TaskRequest
generated fromrmf_api_msgs
instead of pydantic model generated from tortoise modelapi-client
https://github.com/open-rmf/rmf-web/commits/feature/saving-task-request-and-resubmit will need to be updated to use these models instead
Self-checks