Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/save request #842

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Feature/save request #842

merged 6 commits into from
Nov 27, 2023

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Nov 27, 2023

What's new

Endpoint for saving task requests

  • Using TaskRequest generated from rmf_api_msgs instead of pydantic model generated from tortoise model
  • Generated api-client

https://github.com/open-rmf/rmf-web/commits/feature/saving-task-request-and-resubmit will need to be updated to use these models instead

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (574de78) 51.41% compared to head (91cd8de) 51.51%.

Files Patch % Lines
...ckages/api-server/api_server/repositories/tasks.py 87.50% 1 Missing ⚠️
...ckages/api-server/api_server/routes/tasks/tasks.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   51.41%   51.51%   +0.10%     
==========================================
  Files         282      282              
  Lines        7140     7159      +19     
  Branches      960      960              
==========================================
+ Hits         3671     3688      +17     
- Misses       3321     3323       +2     
  Partials      148      148              
Flag Coverage Δ
api-server 81.53% <90.00%> (+0.05%) ⬆️
dashboard 16.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaronchongth aaronchongth merged commit 52a7d14 into main Nov 27, 2023
5 checks passed
@aaronchongth aaronchongth deleted the feature/save-request branch November 27, 2023 07:12
aaronchongth added a commit that referenced this pull request Nov 27, 2023
* New route for saving and getting successfully dispatched requests

Signed-off-by: Aaron Chong <[email protected]>

* Announce failed to dispatch instead of create task

Signed-off-by: Aaron Chong <[email protected]>

* Generate api-client

Signed-off-by: Aaron Chong <[email protected]>

* Use api task request instead of custom ttm pydantic model

Signed-off-by: Aaron Chong <[email protected]>

* Revert alert text change

Signed-off-by: Aaron Chong <[email protected]>

---------

Signed-off-by: Aaron Chong <[email protected]>
(cherry picked from commit 52a7d14)
Signed-off-by: Aaron Chong <[email protected]>
aaronchongth added a commit that referenced this pull request Nov 27, 2023
* New route for saving and getting successfully dispatched requests

Signed-off-by: Aaron Chong <[email protected]>

* Announce failed to dispatch instead of create task

Signed-off-by: Aaron Chong <[email protected]>

* Generate api-client

Signed-off-by: Aaron Chong <[email protected]>

* Use api task request instead of custom ttm pydantic model

Signed-off-by: Aaron Chong <[email protected]>

* Revert alert text change

Signed-off-by: Aaron Chong <[email protected]>

---------

Signed-off-by: Aaron Chong <[email protected]>
(cherry picked from commit 52a7d14)
Signed-off-by: Aaron Chong <[email protected]>
aaronchongth added a commit that referenced this pull request Nov 28, 2023
* Feature/save request (#842)

* New route for saving and getting successfully dispatched requests

Signed-off-by: Aaron Chong <[email protected]>

* Announce failed to dispatch instead of create task

Signed-off-by: Aaron Chong <[email protected]>

* Generate api-client

Signed-off-by: Aaron Chong <[email protected]>

* Use api task request instead of custom ttm pydantic model

Signed-off-by: Aaron Chong <[email protected]>

* Revert alert text change

Signed-off-by: Aaron Chong <[email protected]>

---------

Signed-off-by: Aaron Chong <[email protected]>
(cherry picked from commit 52a7d14)
Signed-off-by: Aaron Chong <[email protected]>

* Regenerating api-client

Signed-off-by: Aaron Chong <[email protected]>

* Query multiple task requests

Signed-off-by: Aaron Chong <[email protected]>

* Lint

Signed-off-by: Aaron Chong <[email protected]>

---------

Signed-off-by: Aaron Chong <[email protected]>
aaronchongth added a commit that referenced this pull request Nov 28, 2023
* Feature/save request (#842)

* New route for saving and getting successfully dispatched requests

Signed-off-by: Aaron Chong <[email protected]>

* Announce failed to dispatch instead of create task

Signed-off-by: Aaron Chong <[email protected]>

* Generate api-client

Signed-off-by: Aaron Chong <[email protected]>

* Use api task request instead of custom ttm pydantic model

Signed-off-by: Aaron Chong <[email protected]>

* Revert alert text change

Signed-off-by: Aaron Chong <[email protected]>

---------

Signed-off-by: Aaron Chong <[email protected]>
(cherry picked from commit 52a7d14)
Signed-off-by: Aaron Chong <[email protected]>

* Regenerating api-client

Signed-off-by: Aaron Chong <[email protected]>

* Passing requests into task data-grid component

Signed-off-by: Aaron Chong <[email protected]>

* Query multiple task requests

Signed-off-by: Aaron Chong <[email protected]>

* Query task requests

Signed-off-by: Aaron Chong <[email protected]>

* Lint

Signed-off-by: Aaron Chong <[email protected]>

* Parse and display pickup and dropoff

Signed-off-by: Aaron Chong <[email protected]>

* Parse automated charging task destination using task state

Signed-off-by: Aaron Chong <[email protected]>

* Task queue table with category as well

Signed-off-by: Aaron Chong <[email protected]>

* Fix tests

Signed-off-by: Aaron Chong <[email protected]>

* Export minimal with new columns

Signed-off-by: Aaron Chong <[email protected]>

* Make requester, pickup and destination not sortable or filterable for now

Signed-off-by: Aaron Chong <[email protected]>

* Reuse getAllTaskRequests

Signed-off-by: Aaron Chong <[email protected]>

* Revert reuse as it requires adding dependencies

Signed-off-by: Aaron Chong <[email protected]>

* Revert category column, as filtering and sorting is convoluted for now

Signed-off-by: Aaron Chong <[email protected]>

* Added comment regarding not reusing getAllTaskRequests

Signed-off-by: Aaron Chong <[email protected]>

---------

Signed-off-by: Aaron Chong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant